Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename test for k8s-labs #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rename test for k8s-labs #68

wants to merge 1 commit into from

Conversation

double16
Copy link
Contributor

@double16 double16 commented Mar 8, 2024

The test fails because the ports aren't mapped correctly with nginx. I can't readily tell which ports are supposed to be mapped. I had to move the nginx conf to the start operation because the cluster IP isn't available until minikube is started.

@JGillam JGillam requested a review from corysabol March 9, 2024 13:59
@JGillam
Copy link
Member

JGillam commented Mar 9, 2024

I'm going to nudge @corysabol on this one since he knows more about what's going on with the k8s labs.

@corysabol
Copy link
Contributor

corysabol commented Mar 9, 2024 via email

@corysabol
Copy link
Contributor

I suspect the test is failing in the runner because the minikube driver is set to --docker in the k8s-labs setup.sh. The test log shows it exiting the cluster setup here - https://github.com/SamuraiWTF/katana/actions/runs/8207803587/job/22449894918?pr=68#step:6:85

I imagine the test github action is itself a docker container so getting the docker driver to work would take some tweaking most likely. In the samuraivm itself I think there was some hackery I had to do to get the docker driver to work as root. I'd like to find a better solution to this, but I also had a lot of issues when using --driver=none. I should re-investigate this relatively soon. I think the test itself looks fine at a cursory glance though.

@double16
Copy link
Contributor Author

I don't think the ports are correct. This is running from a VM on my local:

vagrant@vagrant:~$ curl --verbose http://192.168.58.2:31337
*   Trying 192.168.58.2:31337...
* connect to 192.168.58.2 port 31337 failed: Connection refused
* Failed to connect to 192.168.58.2 port 31337 after 0 ms: Connection refused
* Closing connection 0
curl: (7) Failed to connect to 192.168.58.2 port 31337 after 0 ms: Connection refused
vagrant@vagrant:~$ curl --verbose http://192.168.58.2:31380
*   Trying 192.168.58.2:31380...
* connect to 192.168.58.2 port 31380 failed: Connection refused
* Failed to connect to 192.168.58.2 port 31380 after 2 ms: Connection refused
* Closing connection 0
curl: (7) Failed to connect to 192.168.58.2 port 31380 after 2 ms: Connection refused

ss -antup:

vagrant@vagrant:~$ ss -antup
Netid              State               Recv-Q               Send-Q                              Local Address:Port                              Peer Address:Port               Process              
udp                UNCONN              0                    0                                   127.0.0.53%lo:53                                     0.0.0.0:*                                       
udp                UNCONN              0                    0                                  10.0.2.15%eth0:68                                     0.0.0.0:*                                       
tcp                LISTEN              0                    511                                       0.0.0.0:80                                     0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                127.0.0.53%lo:53                                     0.0.0.0:*                                       
tcp                LISTEN              0                    128                                       0.0.0.0:22                                     0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                    127.0.0.1:32768                                  0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                    127.0.0.1:32769                                  0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                    127.0.0.1:32770                                  0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                    127.0.0.1:32771                                  0.0.0.0:*                                       
tcp                LISTEN              0                    4096                                    127.0.0.1:32772                                  0.0.0.0:*                                       
tcp                ESTAB               0                    0                                       10.0.2.15:22                                    10.0.2.2:54365                                   
tcp                LISTEN              0                    511                                          [::]:80                                        [::]:*                                       
tcp                LISTEN              0                    128                                          [::]:22                                        [::]:*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corysabol corysabol Awaiting requested review from corysabol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@double16 @JGillam @corysabol